Fix to npm run build error and fire-migrate not found error#35
Open
19007361 wants to merge 2 commits intocodediodeio:masterfrom
Open
Fix to npm run build error and fire-migrate not found error#3519007361 wants to merge 2 commits intocodediodeio:masterfrom
19007361 wants to merge 2 commits intocodediodeio:masterfrom
Conversation
jamesanglin
approved these changes
Jan 30, 2020
jamesanglin
left a comment
jamesanglin
left a comment
There was a problem hiding this comment.
The project would not build until I pulled these changes in. Now it works like a charm.
Can confirm this worked perfectly on the first try. Thank you so much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issues #32 and #25
Typescript needed to be updated along with the @types/node
README updated to make it clear that npm run build-link will find fire-migrate (and also, let's put fire-migrate in the command description itself.
I have a lot of appreciation for this code, it is incredibly useful.