Skip to content

Dev #3405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bernardhanna merged 2 commits into from
Feb 25, 2026
Merged

Dev #3405

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e6553c
certs fix
bernardhanna Feb 25, 2026
9eeebbe
Merge pull request #3404 from codeeu/week_10_feb
bernardhanna Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
143 changes: 88 additions & 55 deletions app/Console/Commands/CertificatePreflight.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@ class CertificatePreflight extends Command
{--edition=2025 : Target edition year}
{--type=all : excellence|super-organiser|all}
{--limit=0 : Max records to test (0 = all)}
{--batch-size=500 : Process in batches; 0 = single run}
{--only-pending : Test only rows without certificate_url}
{--export= : Optional CSV path for failures}';
{--export= : Optional CSV path for failures (only failures written)}';

protected $description = 'Dry-run compile certificates (no S3 upload, no DB updates) and report failures';

Expand All @@ -22,6 +23,7 @@ public function handle(): int
$edition = (int) $this->option('edition');
$typeOption = strtolower(trim((string) $this->option('type')));
$limit = max(0, (int) $this->option('limit'));
$batchSize = max(0, (int) $this->option('batch-size'));
$onlyPending = (bool) $this->option('only-pending');
$exportPath = trim((string) $this->option('export'));

Expand All @@ -31,82 +33,113 @@ public function handle(): int
return self::FAILURE;
}

$query = Excellence::query()
$baseQuery = Excellence::query()
->where('edition', $edition)
->whereIn('type', $types)
->with('user')
->orderBy('type')
->orderBy('id');

if ($onlyPending) {
$query->whereNull('certificate_url');
$baseQuery->whereNull('certificate_url');
}

if ($limit > 0) {
$query->limit($limit);
}

$rows = $query->get();
if ($rows->isEmpty()) {
$totalToTest = (clone $baseQuery)->count();
if ($totalToTest === 0) {
$this->info('No recipients found for the selected filters.');
return self::SUCCESS;
}

$failures = [];
$ok = 0;
$bar = $this->output->createProgressBar($rows->count());
$bar->start();

foreach ($rows as $e) {
$bar->advance();
$user = $e->user;
if (! $user) {
$failures[] = $this->failureRow($e, '', 'Missing related user record.');
continue;
}
if (! $user->email) {
$failures[] = $this->failureRow($e, (string) $user->email, 'Missing user email.');
continue;
}
if ($limit > 0) {
$totalToTest = min($totalToTest, $limit);
}

$name = $e->name_for_certificate ?? trim(($user->firstname ?? '') . ' ' . ($user->lastname ?? ''));
if ($name === '') {
$failures[] = $this->failureRow($e, (string) $user->email, 'Empty certificate holder name.');
continue;
$batchSize = $batchSize > 0 ? $batchSize : $totalToTest;
$totalBatches = (int) ceil($totalToTest / $batchSize);
$this->info("Dry-run preflight: {$totalToTest} recipients in {$totalBatches} batch(es) of up to {$batchSize}. Failures only.");
$this->newLine();

$allFailures = [];
$totalTested = 0;
$totalPassed = 0;
$offset = 0;

while ($offset < $totalToTest) {
$take = min($batchSize, $totalToTest - $offset);
$query = (clone $baseQuery)->offset($offset)->limit($take);
$rows = $query->get();
if ($rows->isEmpty()) {
break;
}

$certType = $e->type === 'SuperOrganiser' ? 'super-organiser' : 'excellence';
$numberOfActivities = $e->type === 'SuperOrganiser' ? (int) $user->activities($edition) : 0;

try {
$cert = new CertificateExcellence(
$edition,
$name,
$certType,
$numberOfActivities,
(int) $user->id,
(string) $user->email
);
$cert->preflight();
$ok++;
} catch (\Throwable $ex) {
$failures[] = $this->failureRow($e, (string) $user->email, $ex->getMessage());
$batchNum = (int) floor($offset / $batchSize) + 1;
$bar = $this->output->createProgressBar($rows->count());
$bar->setFormat(" Batch %current%/%max% [%bar%] %percent:3s%% — failures this batch: ");
$bar->start();

$batchFailures = 0;
foreach ($rows as $e) {
$user = $e->user;
if (! $user) {
$allFailures[] = $this->failureRow($e, '', 'Missing related user record.');
$batchFailures++;
$bar->advance();
continue;
}
if (! $user->email) {
$allFailures[] = $this->failureRow($e, (string) $user->email, 'Missing user email.');
$batchFailures++;
$bar->advance();
continue;
}

$name = $e->name_for_certificate ?? trim(($user->firstname ?? '') . ' ' . ($user->lastname ?? ''));
if ($name === '') {
$allFailures[] = $this->failureRow($e, (string) $user->email, 'Empty certificate holder name.');
$batchFailures++;
$bar->advance();
continue;
}

$certType = $e->type === 'SuperOrganiser' ? 'super-organiser' : 'excellence';
$numberOfActivities = $e->type === 'SuperOrganiser' ? (int) $user->activities($edition) : 0;

try {
$cert = new CertificateExcellence(
$edition,
$name,
$certType,
$numberOfActivities,
(int) $user->id,
(string) $user->email
);
$cert->preflight();
$totalPassed++;
} catch (\Throwable $ex) {
$allFailures[] = $this->failureRow($e, (string) $user->email, $ex->getMessage());
$batchFailures++;
}
$bar->advance();
}

$bar->finish();
$totalTested += $rows->count();
$this->line(" {$batchFailures} | Total: {$totalTested}/{$totalToTest} tested, " . count($allFailures) . " failures.");
$offset += $rows->count();
}
$bar->finish();
$this->newLine(2);

$this->info("Preflight complete. Tested: {$rows->count()}, Passed: {$ok}, Failed: " . count($failures));
$this->newLine();
$this->info("Preflight complete. Tested: {$totalTested}, Passed: {$totalPassed}, Failed: " . count($allFailures));

if (! empty($failures)) {
$show = array_slice($failures, 0, 20);
if (! empty($allFailures)) {
$show = array_slice($allFailures, 0, 20);
$this->table(['id', 'type', 'user_id', 'email', 'name', 'error'], $show);
if (count($failures) > 20) {
$this->line('Showing first 20 failures. Use --export for full list.');
if (count($allFailures) > 20) {
$this->line('(First 20 failures above. Full list in CSV if --export used.)');
}
}

if ($exportPath !== '') {
if ($exportPath !== '' && ! empty($allFailures)) {
$path = $this->resolvePath($exportPath);
$dir = dirname($path);
if (! is_dir($dir) && ! @mkdir($dir, 0775, true) && ! is_dir($dir)) {
Expand All @@ -119,7 +152,7 @@ public function handle(): int
return self::FAILURE;
}
fputcsv($fh, ['id', 'type', 'edition', 'user_id', 'email', 'name_for_certificate', 'error']);
foreach ($failures as $row) {
foreach ($allFailures as $row) {
fputcsv($fh, [
$row['id'],
$row['type'],
Expand All @@ -131,7 +164,7 @@ public function handle(): int
]);
}
fclose($fh);
$this->info("Exported failures CSV: {$path}");
$this->info("Exported failures only: {$path}");
}

return self::SUCCESS;
Expand Down
Loading