Skip to content

feat/deprecateTestFactory#343

Merged
codefriar merged 3 commits intomainfrom
feat/deprecateTestFactory
Jun 8, 2025
Merged

feat/deprecateTestFactory#343
codefriar merged 3 commits intomainfrom
feat/deprecateTestFactory

Conversation

@codefriar
Copy link
Owner

@codefriar codefriar commented Jun 8, 2025

Summary by CodeRabbit

  • Refactor: Updated method calls and field names in FeatureFlagTests.cls, SafelyTests.cls, and ULIDTests.cls for consistency and correctness.
  • Style: Corrected the case of annotations and method references in PolyfillsTests.cls.
  • Chore: Removed unused ApexClass XML file TestFactory.cls-meta.xml.
  • Documentation: Added "ulid" to the project dictionary to enhance code readability and understanding.

codefriar added 2 commits June 8, 2025 12:26
TestFactory is dead. Long live SObjectFactory
TestFactory is dead. Long live SObjectFactory
@github-actions
Copy link

github-actions bot commented Jun 8, 2025

Image description CodeRabbit

Walkthrough

This pull request includes a series of changes primarily focused on improving the consistency and correctness of method names, annotations, and field references across several Apex classes. It also includes the removal of an XML file and the addition of a new word to a dictionary.

Changes

File(s) Summary
force-app/main/default/classes/feature flags/tests/FeatureFlagTests.cls,
force-app/main/default/classes/safely/tests/SafelyTests.cls,
force-app/main/default/classes/ULID/tests/ULIDTests.cls
Updated method calls, replaced class references, corrected field names, and standardized capitalization for better consistency.
force-app/main/default/classes/polyfills/tests/PolyfillsTests.cls Improved method annotations, method names, and variable assignments for better clarity and maintainability.
force-app/main/default/classes/test utilities/TestFactory.cls-meta.xml Removed the entire content of this ApexClass XML file.
.idea/dictionaries/project.xml Added the word "ulid" to the list of words in the XML file, enhancing the project's custom dictionary.

🐇💻

In the land of code where the shadows lie,
A rabbit hopped with a watchful eye.
With every leap, a bug was squashed,
And every line, thoroughly washed.

The fields were named with proper care,
And methods called from here and there.
An XML file ceased to be,
While a new word joined the spree.

So let's celebrate this coding feat,
With carrots crunchy, and oh so sweet! 🥕🎉


Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between ba4fa73 and 7744de5 commits.
Files selected (5)
  • force-app/main/default/classes/feature flags/tests/FeatureFlagTests.cls (1)
  • force-app/main/default/classes/polyfills/tests/PolyfillsTests.cls (13)
  • force-app/main/default/classes/safely/tests/SafelyTests.cls (15)
  • force-app/main/default/classes/test utilities/TestFactory.cls (1)
  • force-app/main/default/classes/test utilities/TestFactory.cls-meta.xml (1)
Files not summarized due to errors (1)
  • force-app/main/default/classes/test utilities/TestFactory.cls (diff tokens exceeds limit)
Files skipped from review due to trivial changes (2)
  • force-app/main/default/classes/polyfills/tests/PolyfillsTests.cls
  • force-app/main/default/classes/safely/tests/SafelyTests.cls
Review comments generated (1)
  • Review: 0
  • LGTM: 1

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 7744de5 and 2d1a59f commits.
Files selected (3)
  • .idea/dictionaries/project.xml (1)
  • force-app/main/default/classes/ULID/tests/ULIDTests.cls (1)
  • force-app/main/default/classes/feature flags/tests/FeatureFlagTests.cls (1)
Files ignored due to filter (2)
  • config/project-scratch-def.json
  • package.json
Files skipped from review due to trivial changes (2)
  • .idea/dictionaries/project.xml
  • force-app/main/default/classes/ULID/tests/ULIDTests.cls
Review comments generated (1)
  • Review: 0
  • LGTM: 1

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@codefriar codefriar merged commit 6fb568c into main Jun 8, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant