[심예진] sprint3#72
Merged
baeggmin merged 8 commits intocodeit-bootcamp-frontend:Basic-심예진from Jun 16, 2025
Hidden character warning
The head ref may contain hidden characters: "Basic-\uc2ec\uc608\uc9c4-sprint3"
Merged
Conversation
added 8 commits
June 11, 2025 19:33
baeggmin
approved these changes
Jun 16, 2025
Collaborator
baeggmin
left a comment
baeggmin
left a comment
There was a problem hiding this comment.
지난 리뷰를 꼼꼼히 반영해주셨군요!
디렉토리 구조, 시맨틱한 네이밍, 반응형 대응까지 코드가 정말 많이 깔끔해진 것 같아요. 👍👍👍
고생 많으셨습니다! 😊
| } | ||
|
|
||
| form { | ||
| /* form { |
Collaborator
There was a problem hiding this comment.
학습 단계에서는 큰 상관 없지만, 나중에 협업이나 실무할 때 dead code 는 제거해주시는게 원칙입니다!
| <link href="https://fonts.googleapis.com/css2?family=Noto+Sans+KR:wght@100..900&display=swap" rel="stylesheet"> | ||
| <title>판다마켓</title> | ||
| <!-- Open Graph (페북, 카카오, 디스코드)--> | ||
| <meta property="og:title" content="판다 마켓"> |
| <a href="/items" class="looking-button">구경하러 가기</a> | ||
| </div> | ||
| <img class="hi" src="image/Img_home_top.png" alt="상단배경"> | ||
| <div class="ppanda"> |
Collaborator
There was a problem hiding this comment.
ppanda -> 오타인거같아요!
그리고 사소하지만 .hi .bye .twoppanda 등의 클래스 명은 의미가 조금 모호한 것 같아요. 조금 더 역할 기반 네이밍을 해주시면 좋을 듯 합니다. (ex: panda-top-image, panda-bottom-image 등)
| display: flex; | ||
| flex-direction: column; | ||
| width: 640px; | ||
| width: 100%;; |
Collaborator
There was a problem hiding this comment.
고정값(640px)을 줄이고 width: 100% 사용해서 유연한 레이아웃으로 리팩토링한 점 훌륭합니다! 👏
| input { | ||
| width: 640px; | ||
| width: 100%; | ||
| /* width: 640px; */ |
Collaborator
There was a problem hiding this comment.
여기도 dead code 가 보이네요!
PR 후에 File changed 목록을 쭉 훑어보면서 dead code가 있는지 확인해보는 습관을 들이면 실수 방지에 도움이 됩니다!
| font-size: 24px; | ||
| } | ||
|
|
||
| @media (min-width: 768px) and (max-width: 1199px) { |
Collaborator
There was a problem hiding this comment.
모바일/태블릿/PC 반응형 대응이 잘 되어 있고, 브레이크포인트 구분도 명확히 설정해주셨습니다! 👏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요구사항
공통
랜딩 페이지
로그인, 회원가입 페이지 공통
심화
주요 변경사항
스크린샷
멘토에게