Open
Conversation
…ssion3 이준오 Feature/mission3
fix twisting branches
rdd9223
approved these changes
Nov 19, 2025
Collaborator
rdd9223
left a comment
rdd9223
left a comment
There was a problem hiding this comment.
지금 mission9/node_modules가 ignore되지 않아서 merge가 불가능한 상태입니다! 꼭 dist, node_modules, coverage 등 실제 git으로 관리되지 않아도 되는 큰 파일들은 모두 ignore처리해주세요.
추가로 테스트부분은 구현하지 않으신 것 같아요. 시간이 부족해서인지, 아니면 개인적인 이유에서인지 멘토링시간에 이야기해보죠!
node_modules ignore이후에 merge 해주세요.
Comment on lines
+4
to
+8
| mission2 | ||
| mission3 | ||
| mission4 | ||
| mission6 | ||
| mission8 |
Collaborator
There was a problem hiding this comment.
지난 미션은 왜 ignore 처리해두신건가요? 굳이 ignore 처리 안해도 될 것 같은데, 아마 git을 사용하는데 어려움이 있으신 것 같아요. 이건 멘토링 시간에 이야기 해보죠!
Comment on lines
+9
to
+10
| mission9/dist | ||
| mission9/generated/prisma |
Collaborator
There was a problem hiding this comment.
여기서 node_modules를 ignore처리 해주세요.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게