feat: implement Gemini LLM client with full API support #3018
+803
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement GeminiLlmClient with complete support for Google Gemini API: - Add chat() method for synchronous completions - Add streamChat() method for streaming responses - Add isAvailable() method for availability checks - Convert OpenAI-style messages to Gemini format - Handle system messages via systemInstruction - Convert "assistant" role to "model" for Gemini - Use parts array for content structure - Support generationConfig for temperature and maxOutputTokens - Update default model to gemini-2.5-flash Add comprehensive unit tests for: - Message conversion and role mapping - Request body building - API URL construction - Configuration fallback handling
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a complete Gemini LLM client with synchronous and streaming chat capabilities, message format conversion, and comprehensive test coverage.
Changes:
- Implements
chat()andstreamChat()methods with HTTP client integration and JSON response parsing - Adds message conversion logic to transform OpenAI-style messages to Gemini format (system messages via systemInstruction, assistant→model role mapping)
- Updates default model from gemini-1.5-pro to gemini-2.5-flash
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/java/org/codelibs/fess/llm/gemini/GeminiLlmClient.java | Implements chat and streaming methods with message conversion, API URL building, and HTTP client integration |
| src/main/resources/fess_config.properties | Updates default Gemini model to gemini-2.5-flash |
| src/test/java/org/codelibs/fess/llm/gemini/GeminiLlmClientTest.java | Adds comprehensive unit tests for message conversion, request building, and configuration handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement GeminiLlmClient with complete support for Google Gemini API:
Add comprehensive unit tests for: