Global device symbol management proposal.#132
Open
Naghasan wants to merge 1 commit intocodeplaysoftware:masterfrom
Open
Global device symbol management proposal.#132Naghasan wants to merge 1 commit intocodeplaysoftware:masterfrom
Naghasan wants to merge 1 commit intocodeplaysoftware:masterfrom
Conversation
Some devices can manage global values to push and pull different values. In the CUDA runtime, this is covered by cudaMemcpyToSymbol/cudaMemcpyFromSymbol functions. But other APIs may offer similar functionalities. This proposal add the possibilities to manage such global values via a new class and new sycl::handler member functions. The proposal is still a bit incomplete as regular C++ global variable can potentially be handled by the sycl::handler extension without requiring the new 'sycl::symbol' class. but limitation have yet to be explored.
keryell
reviewed
Aug 5, 2020
Contributor
keryell
left a comment
keryell
left a comment
There was a problem hiding this comment.
That looks quite reasonable.
Even some C++17 here. :-)
I am curious about the mutable kernel lambdas. Is this a side effect of the simple mock-up?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some devices can manage global values to push and pull different values.
In the CUDA runtime, this is covered by cudaMemcpyToSymbol/cudaMemcpyFromSymbol functions.
But other APIs may offer similar functionalities.
This proposal add the possibilities to manage such global values via a new class and new sycl::handler member functions.
The proposal is still a bit incomplete as regular C++ global variable can potentially be handled by the sycl::handler extension
without requiring the new 'sycl::symbol' class. but limitation have yet to be explored.