Use navbar color scheme setting to draw background of logo #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Navbar color scheme setting is used in the front-end (by bootstrap) to color the navbar which sits behind the logo. Generally speaking, if the logo is dark a light navbar is used, if the logo is light a dark navbar is used.
We also show the client's logo in the wagtail admin, as a friendly sight, and also to help differentiate multiple wagtail admins.
However, dark logos are usually unreadable or look terrible against the dark-gray wagtail admin. This change draws a light background behind the logo in the wagtail admin when the light navbar color scheme is selected.