Conversation
Contributor
|
Tests are failing, please fix. @Exordian do you agree with storing the current challenge inside the session like introduced here? |
When participating in a challenge, there are several tasks/levels. New tasks can only be shown respectively downloaded when the previous challenge was submitted and produced the correct results. Previously, this was just handled on the client side and users could have downloaded the task description of the next level by calling the corresponding API. This is not possible anymore as the permission to download the file is now checked server-side. This is done by setting a session attribute named "CURRENT_CHALLENGE" which is set when the challenge is viewed and allows the server to quickly check in what level the user is.
4966d43 to
556f41a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When participating in a challenge, there are several tasks/levels. New tasks can only be shown
respectively downloaded when the previous challenge was submitted and produced the
correct results.
Previously, this was just handled on the client side and users could have downloaded the task
description of the next level by calling the corresponding API. This is not possible anymore as
the permission to download the file is now checked server-side.
This is done by setting a session attribute named "CURRENT_CHALLENGE" which is set when
the challenge is viewed and allows the server to quickly check in what level the user is.