Merged
Conversation
The handlerCache in WriterFactory provided no benefit. buildWriteHandlerMap() always created a new WriteHandlerMap on return, regardless of cache hit or miss. This removes the cache and its synchronized block, eliminating unnecessary contention overhead.
The handlerCache in ReaderFactory used a synchronized block that caused contention. The cache benefit was outweighed by the synchronization overhead. With this change, Cache.java is no longer used and has been removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
----- d85f75d
Remove cache from ReaderFactory and delete Cache.java
The handlerCache in ReaderFactory used a synchronized block that caused
contention. The cache benefit was outweighed by the synchronization
overhead.
----- 9c2a8a7
With this change, Cache.java is no longer used and has been removed.
Remove cache from WriterFactory
The handlerCache in WriterFactory provided no benefit.
buildWriteHandlerMap() always created a new WriteHandlerMap on return,
regardless of cache hit or miss.
This removes the cache and its synchronized block, eliminating
unnecessary contention overhead.