-
Notifications
You must be signed in to change notification settings - Fork 167
MacOS compatibility #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
MacOS compatibility #345
Conversation
| SurvivePose pose = pose_event->pose; | ||
| FLT timecode = pose_event->time; | ||
| /*printf("%s %s (%7.3f): %f %f %f %f %f %f %f\n", survive_simple_object_name(pose_event->object), | ||
| printf("%s %s (%7.3f): %f %f %f %f %f %f %f\n", survive_simple_object_name(pose_event->object), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this not commented out?
| #include <stdbool.h> | ||
|
|
||
| #ifdef __APPLE__ | ||
| #include <stdlib.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably include stdlib.h directly on all platforms rather than just malloc.h on everything else.
| } | ||
| } | ||
| void survive_kalman_lighthouse_ootx(SurviveKalmanLighthouse *tracker) { | ||
| if (tracker == NULL) return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it often NULL ?
| find_library(HIDAPI_LIBRARY hidapi PATHS /opt/homebrew/lib /usr/local/lib) | ||
| if(HIDAPI_LIBRARY) | ||
| list(APPEND ADDITIONAL_LIBRARIES ${HIDAPI_LIBRARY}) | ||
| include_directories(/opt/homebrew/include /usr/local/include) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm that seems a bit too wide, there's no target available from CMake ?
Tested and working with Vive Tracker 3.0 and Base Station 2.0 on a MacBook Pro M4.