DRYD-1851: Report > Public Art > Full object with place details #493
+928
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Converting it to draft, as we need to provide two reports: https://collectionspace.atlassian.net/browse/DRYD-1851?focusedCommentId=67994 |
…or role in distinct columns;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
For the "Public Art > Full object with place details" report, it aggregates all materials, work types, creators (along with their roles). It also adds one more report that combines creator and creator role columns into a single one.
Why are we doing this? (with JIRA link)
Report should produce output of multiple creators, work types and materials and not just the first one. https://collectionspace.atlassian.net/browse/DRYD-1851
How should this be tested? Do these changes have associated tests?
Using the public art profile, please create an object with multiple materials, work types and creators with roles. Run the "Full object with place details" report and confirm that multiple values are displayed, instead of only the first one. The values are separated by semicolon. Then run the "Full Object with Place Details: Creator Name and Role Combined" report and confirm that multiple values are displayed as specified. The Creator and Creator Role columns are combined into a single column "Creator (Creator Role)".
Dependencies for merging? Releasing to production?
No dependencies
Has the application documentation been updated for these changes?
The relevant report documentation should be updated accordingly
Did someone actually run this code to verify it works?
@spirosdi ran this locally.