Skip to content

Fix: Prevent partial directory matching in change detection#31

Open
bijantavakoli wants to merge 1 commit intocolpal:masterfrom
bijantavakoli:patch-1
Open

Fix: Prevent partial directory matching in change detection#31
bijantavakoli wants to merge 1 commit intocolpal:masterfrom
bijantavakoli:patch-1

Conversation

@bijantavakoli
Copy link

Fixes a bug where directory names that are substrings of others (e.g., shopify_general vs shopify_general_v2) caused false positive builds.

The logic has been updated to strictly enforce directory boundaries (using path.sep) so that changes in a _v2 folder do not trigger builds for the base folder.

Please see the Issue for more details: #30

Fixes a bug where directory names that are substrings of others (e.g., shopify_general vs shopify_general_v2) caused false positive builds.

The logic has been updated to strictly enforce directory boundaries (using path.sep) so that changes in a _v2 folder do not trigger builds for the base folder.
@nafarlee
Copy link
Member

nafarlee commented Dec 22, 2025

This PR and your corresponding issue seem correct on the merits. However, this action has gone unmaintained for years, due in part to our recommendation shifting overtime:

I think it best for current users of colpal/actions-batch-docker to migrate to one of the approaches above. I don't mind merging this PR and releasing a new version...but it might not be worth putting any additional time into maintaining/using this action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants