Fix: Prevent partial directory matching in change detection#31
Open
bijantavakoli wants to merge 1 commit intocolpal:masterfrom
Open
Fix: Prevent partial directory matching in change detection#31bijantavakoli wants to merge 1 commit intocolpal:masterfrom
bijantavakoli wants to merge 1 commit intocolpal:masterfrom
Conversation
Fixes a bug where directory names that are substrings of others (e.g., shopify_general vs shopify_general_v2) caused false positive builds. The logic has been updated to strictly enforce directory boundaries (using path.sep) so that changes in a _v2 folder do not trigger builds for the base folder.
Member
|
This PR and your corresponding issue seem correct on the merits. However, this action has gone unmaintained for years, due in part to our recommendation shifting overtime:
I think it best for current users of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where directory names that are substrings of others (e.g., shopify_general vs shopify_general_v2) caused false positive builds.
The logic has been updated to strictly enforce directory boundaries (using path.sep) so that changes in a _v2 folder do not trigger builds for the base folder.
Please see the Issue for more details: #30