Skip to content

feat: move gse & svm between ConnectedAP#4

Closed
salvar3nga wants to merge 30 commits intocom-pas:mainfrom
salvar3nga:feat/move_gse_n_svm_between_connectedAP
Closed

feat: move gse & svm between ConnectedAP#4
salvar3nga wants to merge 30 commits intocom-pas:mainfrom
salvar3nga:feat/move_gse_n_svm_between_connectedAP

Conversation

@salvar3nga
Copy link
Collaborator

@salvar3nga salvar3nga commented Apr 8, 2025

Description

Info: In order to use the newly wizard translations, the following PR on OpenSCD (openscd/open-scd#1655) needs to merged and then pulled into this repo.

📷 Demo screen shots

Bildschirmfoto 2025-04-09 um 13 01 58

->

Bildschirmfoto 2025-04-09 um 13 01 21


return [
{
title: get('wizard.title.selectAp'),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently using the translation added on OpenSCD Repo:
openscd/open-scd#1655

@salvar3nga salvar3nga marked this pull request as ready for review April 9, 2025 13:53
></mwc-fab
></action-icon>`;
></mwc-fab>
${hasMoreThanOneConnectedAP ?
Copy link
Collaborator Author

@salvar3nga salvar3nga Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternatively, instead of not displaying the new icon if there is only one connectedAP we could disable it by passing the ?disabled={hasOnlyOneConnectedAP}.

However, additional stylings are required for the icon

@salvar3nga salvar3nga self-assigned this Apr 30, 2025
trusz pushed a commit that referenced this pull request May 2, 2025
…tract-openscd-dependencies

feature: add translations for editor-plugins
@trusz trusz closed this May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants