Conversation
comatory
force-pushed
the
fix-pattern-matching
branch
from
61d479f to
0679609
Compare
comatory
force-pushed
the
fix-pattern-matching
branch
2 times, most recently
from
9de7552 to
336ce25
Compare
comatory
force-pushed
the
fix-pattern-matching
branch
from
336ce25 to
43a40c4
Compare
comatory
force-pushed
the
fix-pattern-matching
branch
from
43a40c4 to
795bde6
Compare
Owner
Author
|
Will do manual tests to validate the changes, then will release it as |
comatory
force-pushed
the
fix-pattern-matching
branch
from
8fb9830 to
f8cc75a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with incorrect implementation of CODEOWNERS spec. The initial approach was very naive, basically just matching substrings, but there's more to it such as:
**patterns*.*extension patternsI ended up generating tests according to that spec and integrated the codebase to use package management via
luarocks. Tests are usingluaunit.