Merged
Conversation
Owner
comatory
commented
Apr 13, 2025
comatory
commented
- convert color buttons to web components
- convert tool button to web components + refactors
- convert variant button to wc
- create base button component and re-use it
- re-use UI button web component for main UI
- re-use click method
- refactor from using of callbacks to abort controller signal
- handle activation of buttons in top level
- enclose click handlers to variant button
- simplify code by removing blocking interactions
- simplify code for detecting clicks
- update cache
this reduces the code which handles variants panel and co-locates the functionality inside of the class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.