Skip to content

Improve handling of surprises in the migrations folder #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
salomvary wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve handling of surprises in the migrations folder #38

salomvary wants to merge 2 commits into from

Conversation

@salomvary
Copy link

@salomvary salomvary commented Dec 1, 2016

  • Ignore hidden files
  • Print an error message with the migration file path if parsing fails for some reason

@salomvary
Add path to exceptions thrown when parsing migration files
34a9e50 
As error handling of the cli consists of printing the message of
exceptions populated to the main method, it is important to have useful
messages on these exceptions.

An example of such an exception is
`Source.fromInputStream(resource).getLines()` choking on files that can
not be parsed with text encoding (eg. binary swap files saved by Vim)
with the following message: "Input length = 1". There is no way to tell
what went wrong with which file.

This change will turn that useless error into something like this:
"Error parsing migration file migrations/.some-migration-file.cql.swp: Input length = 1"

Still not perfect but much better than before.
@salomvary
Ignore hidden files in migration folder
8ed427c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@salomvary