Fix warning when subdivision dataset is null or empty when requesting…#228
Open
io-mark wants to merge 1 commit intocommerceguys:mainfrom
Open
Fix warning when subdivision dataset is null or empty when requesting…#228io-mark wants to merge 1 commit intocommerceguys:mainfrom
io-mark wants to merge 1 commit intocommerceguys:mainfrom
Conversation
… an illegal combination of parents
|
Why do you return an empty array instead of the original $definitions? I don't understand the code enough to say which one would be better, but my intuition would go for $definitions instead of []. |
|
The method name is somewhat poorly named as it returns mapped subdivisions. An empty array is the correct return value here |
Contributor
|
This PR needs a test that will confirm the existence of the bug (and the fix). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… an illegal combination of parents