issue #230: fix Vietnam subdivision mapping to match VN.json#240
Merged
bojanz merged 1 commit intocommerceguys:mainfrom Feb 13, 2026
Merged
Conversation
Contributor
|
Thanks! |
Contributor
|
Committed a followup: b4e4b6a It allows people to update from the old two-letter codes to the ones shipped in 2.2.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VN.json file was updated with new subdivision IDs but the SubdivisionUpdater mapping was not updated accordingly, causing mismatches between codes and names.
For example:
This commit updates the Vietnam mapping in SubdivisionUpdater to match the current VN.json file data.
The mapping was generated by reading VN.json and extracting the correct name->ID pairs, ensuring consistency between the JSON data and the legacy name mapping.
Tested with all major Vietnamese cities and provinces.
Fixes #230