Closed
Conversation
Based on https://github.com/monosolutions/tax/tree/CanadianTaxes. * Fixed errors in zone files: - administrative-area whould only have the proince letters - errors in generic names (ex. BC is not on HST, but has its own provincial tax) * Fixed errors in tax types: - outdated values were updated (using this official page as a reference: https://www.canada.ca/en/revenue-agency/services/tax/businesses/topics/gst-hst-businesses/charge-collect-which-rate/calculator.html) - generic labels were fixed to display real spellings (ex. PST in Manitoba is called RST)
* If Store and Client are based in different provinces, provincial tax can only be collected by Store if it's registered in Client's province. * GST and HST can (and have to) be collected everytime by Store from Client in Canada.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many thank to @Fluotonic who create the initial PR at #73