[wip] Build CppInterOp as a shared library on Windows#560
[wip] Build CppInterOp as a shared library on Windows#560mcbarton wants to merge 7 commits intocompiler-research:mainfrom
Conversation
lib/Interpreter/Paths.cpp
Outdated
| // | ||
| // rdar://84036149 | ||
|
|
||
| #if CLANG_VERSION_MAJOR < 20 |
There was a problem hiding this comment.
warning: no header providing "CLANG_VERSION_MAJOR" is directly included [misc-include-cleaner]
lib/Interpreter/Paths.cpp:20:
+ #include <clang/Basic/Version.h>9acb6c2 to
1fe2ac4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #560 +/- ##
=======================================
Coverage 75.93% 75.93%
=======================================
Files 9 9
Lines 3644 3644
=======================================
Hits 2767 2767
Misses 877 877 🚀 New features to boost your workflow:
|
|
clang-tidy review says "All clean, LGTM! 👍" |
da8151c to
5a05154
Compare
fe63480 to
80a8305
Compare
|
Hi @mcbarton, would be great to have this shared lib build in so we can test the dispatch mechanism on windows. Are there any blockers on this PR currently? The logs have expired so I can't tell what was failing |
Hi @aaronj0, I revisited this PR about 2 months ago in my fork, and the blocker was these unresolved external symbol errors https://github.com/mcbarton/CppInterOp/pull/2/checks#step:12:195 . If this can something be solved (which I guess would require changes upstream in llvm) then I should be able to finish this work alongide the work to get cppyy to build and run on Windows (this closed CppInterOp PR https://github.com/compiler-research/CppInterOp/pull/605/files) |
Description
Please include a summary of changes, motivation and context for this PR.
This is a duplicate of #454 , but without the random commit history, and without any conflicts with the main branch.
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist