Skip to content

[wip] Build CppInterOp as a shared library on Windows#560

Draft
mcbarton wants to merge 7 commits intocompiler-research:mainfrom
mcbarton:Windows-shared-library-new
Draft

[wip] Build CppInterOp as a shared library on Windows#560
mcbarton wants to merge 7 commits intocompiler-research:mainfrom
mcbarton:Windows-shared-library-new

Conversation

@mcbarton
Copy link
Collaborator

Description

Please include a summary of changes, motivation and context for this PR.

This is a duplicate of #454 , but without the random commit history, and without any conflicts with the main branch.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

  • I have read the contribution guide recently

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

//
// rdar://84036149

#if CLANG_VERSION_MAJOR < 20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: no header providing "CLANG_VERSION_MAJOR" is directly included [misc-include-cleaner]

lib/Interpreter/Paths.cpp:20:

+ #include <clang/Basic/Version.h>

@mcbarton mcbarton force-pushed the Windows-shared-library-new branch 2 times, most recently from 9acb6c2 to 1fe2ac4 Compare April 13, 2025 19:16
@codecov
Copy link

codecov bot commented Apr 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.93%. Comparing base (208c36a) to head (80a8305).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #560   +/-   ##
=======================================
  Coverage   75.93%   75.93%           
=======================================
  Files           9        9           
  Lines        3644     3644           
=======================================
  Hits         2767     2767           
  Misses        877      877           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@mcbarton mcbarton force-pushed the Windows-shared-library-new branch from da8151c to 5a05154 Compare April 14, 2025 11:01
@mcbarton mcbarton changed the title [wip] Buid CppInterOp as a shared library on Windows [wip] Build CppInterOp as a shared library on Windows Apr 14, 2025
@mcbarton mcbarton force-pushed the Windows-shared-library-new branch from fe63480 to 80a8305 Compare April 17, 2025 07:44
@aaronj0
Copy link
Collaborator

aaronj0 commented Jan 28, 2026

Hi @mcbarton, would be great to have this shared lib build in so we can test the dispatch mechanism on windows. Are there any blockers on this PR currently? The logs have expired so I can't tell what was failing

@mcbarton
Copy link
Collaborator Author

Hi @mcbarton, would be great to have this shared lib build in so we can test the dispatch mechanism on windows. Are there any blockers on this PR currently? The logs have expired so I can't tell what was failing

Hi @aaronj0, I revisited this PR about 2 months ago in my fork, and the blocker was these unresolved external symbol errors https://github.com/mcbarton/CppInterOp/pull/2/checks#step:12:195 . If this can something be solved (which I guess would require changes upstream in llvm) then I should be able to finish this work alongide the work to get cppyy to build and run on Windows (this closed CppInterOp PR https://github.com/compiler-research/CppInterOp/pull/605/files)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants