Remove name param from LookupConstructors#567
Open
jeaye wants to merge 1 commit intocompiler-research:mainfrom
Open
Remove name param from LookupConstructors#567jeaye wants to merge 1 commit intocompiler-research:mainfrom
name param from LookupConstructors#567jeaye wants to merge 1 commit intocompiler-research:mainfrom
Conversation
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This parameter required the unscoped type name, but CppInterOp provides no way of getting that. Every usage of this appears to have a hard-coded type name instead. After speaking with Vassil on Discord, he suggested this additional check may not actually be needed. For now, the param has been kept, to not break existing code. If everything works correctly, we can follow up to remove the param entirely. If this param cannot be removed, please provide a way for the unscoped name to be accessed via CppInterOp.
jeaye
force-pushed
the
lookupconstructors-arg
branch
from
47259b7 to
7da68cf
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
@jeaye, can you rebase this PR? |
Contributor
Author
I'm going to handle all of these changes I have at once, by EOQ. I have over 20 different changes to this lib, locally. Hopefully that's ok. If so, rebasing will be handled then. |
Contributor
|
I'd prefer to have atomic small PRs with tests if possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This parameter required the unscoped type name, but CppInterOp provides
no way of getting that. Every usage of this appears to have a hard-coded
type name instead. After speaking with Vassil on Discord, he suggested
this additional check may not actually be needed.
For now, the param has been kept, to not break existing code. If
everything works correctly, we can follow up to remove the param
entirely.
If this param cannot be removed, please provide a way for the unscoped
name to be accessed via CppInterOp