Out-Of-Process Interpreter for CppInterOp#717
Out-Of-Process Interpreter for CppInterOp#717Vipul-Cariappa merged 73 commits intocompiler-research:mainfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Vipul-Cariappa
force-pushed
the
cppinterop-out
branch
from
c56d565 to
7217df9
Compare
|
Before pushing commits to this PR please either ping me, or delete caches as they are made. This PR has caused a large number of llvm cached builds to be deleted on main, which in turn has required multiple PRs workflow runs to be stopped while the cache is rebuilt. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #717 +/- ##
==========================================
- Coverage 79.39% 79.04% -0.36%
==========================================
Files 9 9
Lines 3780 3879 +99
==========================================
+ Hits 3001 3066 +65
- Misses 779 813 +34
🚀 New features to boost your workflow:
|
Vipul-Cariappa
left a comment
Vipul-Cariappa
left a comment
There was a problem hiding this comment.
Please look at the comments.
The tests are not covering over 1/4 of this patch. @kr-2003 can you improve the coverage? |
Vipul-Cariappa
left a comment
Vipul-Cariappa
left a comment
There was a problem hiding this comment.
You have 65 commits in this one single PR. Out of which ~15 says DO NOT MERGE. Now I am not sure if you want to merge this?
I changed this to "Draft PR" because of the "DO NOT MERGE" in the commit messages.
Can the coverage of this PR be increased? Over a 1/4 of it is not covered by tests. |
Vipul-Cariappa
left a comment
Vipul-Cariappa
left a comment
There was a problem hiding this comment.
This looks good to me.
I am going ahead and merging this PR. If there are any issues that are found, we can fix it in subsequent PRs. If any refactors are required, we can open issues for them.
anutosh491
left a comment
anutosh491
left a comment
There was a problem hiding this comment.
thanks for the work here @kr-2003
@anutosh491 @Vipul-Cariappa I would have liked better coverage for the PR, but am fine with this being merged now, subject to into being squashed and merged, since it has 73 commits, 16 of which say do not merge in the commit message. Just wait for the ci to go green first (ignoring the coverage job which will fail due to lack of coverage) @kr-2003 thanks for all your work getting this PR ready. |
mcbarton
dismissed
their stale review
Dismissing my request for changes, subject to the squash and merge mentioned in this message #717 (comment)
|
@anutosh491 @Vipul-Cariappa before you merge this. Please ping me here or on Discord, since I will need to delete the llvm cache builds this PR makes, and delete now outdated caches on main just before it goes in. |
| CLANG_VERSION="${{ matrix.clang-runtime }}" | ||
| if [[ "$CLANG_VERSION" == "20" && "${{ matrix.cling }}" == "Off" ]]; then | ||
| SUPPRESSION_FILE="../etc/clang${CLANG_VERSION}-valgrind.supp" | ||
| valgrind --show-error-list=yes --track-origins=yes --error-exitcode=1 \ | ||
| --show-leak-kinds=definite,possible \ | ||
| --suppressions="${SUPPRESSION_FILE}" \ | ||
| unittests/CppInterOp/CppInterOpTests/unittests/bin/${{ env.BUILD_TYPE }}/CppInterOpTests | ||
| else | ||
| valgrind --show-error-list=yes --track-origins=yes --error-exitcode=1 \ | ||
| --show-leak-kinds=definite,possible \ | ||
| unittests/CppInterOp/CppInterOpTests/unittests/bin/${{ env.BUILD_TYPE }}/CppInterOpTests | ||
| fi |
There was a problem hiding this comment.
@kr-2003 I believe this Valgrind command change will need to be done in the cppyy repos ci to stop them failing once this is in. Can you open up a PR in the CPyCppyy, cppyy-backend and cppyy repos with this once this PR is in?
6 participants
This PR enables Out-Of-Process Interpreter for CppInterOp.
Under the hood, it uses LLVM's
llvm-jitlink-executorandlib ORC RTto delegate the JIT execution to different process. The user just needs to pass--use-oop-jitflag as ClangArgs while constructing the interpreter to use this feature.