ROOT-Cling specific changes required for Cppyy in ROOT#787
Merged
mcbarton merged 2 commits intocompiler-research:mainfrom Feb 5, 2026
Merged
ROOT-Cling specific changes required for Cppyy in ROOT#787mcbarton merged 2 commits intocompiler-research:mainfrom
mcbarton merged 2 commits intocompiler-research:mainfrom
Conversation
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
reviewed
Jan 27, 2026
lib/CppInterOp/CppInterOp.cpp
Outdated
Comment on lines
2597
to
2599
| #ifdef CPPINTEROP_USE_CLING | ||
| cling::Interpreter::PushTransactionRAII RAII(&I); | ||
| #endif |
Contributor
There was a problem hiding this comment.
Didn't we have something common for both cling and clang-repl?
Collaborator
Author
There was a problem hiding this comment.
Yes. I forgot about that. We have SynthesizingCodeRAII. Will fix it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #787 +/- ##
==========================================
+ Coverage 79.38% 79.46% +0.07%
==========================================
Files 11 11
Lines 3988 4002 +14
==========================================
+ Hits 3166 3180 +14
Misses 822 822
🚀 New features to boost your workflow:
|
aaronj0
force-pushed
the
dev/cling-ROOT
branch
from
dd52406 to
c798d24
Compare
Collaborator
|
@vgvassilev I've rebased this PR and sunk usages of |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
approved these changes
Feb 5, 2026
Contributor
vgvassilev
left a comment
vgvassilev
left a comment
There was a problem hiding this comment.
Lgtm! Consider squash on merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
Everything ROOT specific. Eliminated most, if not all, of the crashes in CppInterOp+Cppyy while using it in ROOT.
Type of change
Please tick all options which are relevant.
Testing
Not sure how I would test it here.
Checklist