[cmake] add dynamic check for libstdc++fs#796
Closed
aaronj0 wants to merge 1 commit intocompiler-research:mainfrom
Closed
[cmake] add dynamic check for libstdc++fs#796aaronj0 wants to merge 1 commit intocompiler-research:mainfrom
aaronj0 wants to merge 1 commit intocompiler-research:mainfrom
Conversation
Based on root-project/root@957ac33 Looking at the compiler version is not enough to know if we really need to link against stdc++fs: """ Whether linking with libstdc++fs is needed depends on the version of libstdc++, not on the compiler. For example, it is possible to use an older library with a newer compiler, or with another compiler that follows a different versioning scheme (for example Clang). """ This adds a similar check in CppInterOp
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #796 +/- ##
=======================================
Coverage 79.40% 79.40%
=======================================
Files 11 11
Lines 3987 3987
=======================================
Hits 3166 3166
Misses 821 821 🚀 New features to boost your workflow:
|
vgvassilev
approved these changes
Feb 4, 2026
Contributor
vgvassilev
left a comment
vgvassilev
left a comment
There was a problem hiding this comment.
Yes, that's the right check! LGTM!
Contributor
|
Should also be closed in favor of #797, I think |
Collaborator
Author
Yes, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on root-project/root@957ac33 Looking at the compiler version is not enough to know if we really need to link against stdc++fs:
"""
Whether linking with libstdc++fs is needed depends on the version of libstdc++, not on the compiler. For example, it is possible to use an older library with a newer compiler, or with another compiler that follows a different versioning scheme (for example Clang). """
This adds a similar check in CppInterOp