Calculate and use scrollbar width as needed#26
Open
Mottie wants to merge 3 commits intocomponent:masterfrom
Open
Calculate and use scrollbar width as needed#26Mottie wants to merge 3 commits intocomponent:masterfrom
Mottie wants to merge 3 commits intocomponent:masterfrom
Conversation
Contributor
Author
|
Updated to fix merge conflicts. Tested in MS Edge and still working as expected. |
Member
|
Hi @Mottie, I've resumed maintenance of this project. Can you please have a second look? If the issue is still reproducible, would you mind rebasing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix #21 for IE (only tested in Edge). The caret will properly align in the demo.
Specific changes:
getScrollbarWidthfunction.This change was tested in the most recent versions of Chrome, Firefox and Opera. I don't own an Apple device, so I didn't test it in Safari.
* NOTE * An issue still remains with IE because the
inputdoes not return ascrollLeftvalue (other than zero). So, as you type in the input, it scrolls to keep the caret in view, but the calculated caret position continues to increase.