-
Notifications
You must be signed in to change notification settings - Fork 6
Support instrumenting components! #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ejrgilbert
wants to merge
59
commits into
main
Choose a base branch
from
feature/support-components
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ented (much cleaner this way)
…o the type of the item inside the component)
9593884 to
46ae8d8
Compare
…ts that depend on index space scoping
…it reveals to be dependent on index space scoping)
… encode logic. Need to flesh out the rest of the index fixing logic to get back to where I was.
…ase of the encode logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core Functionality
whamm(currently not reordering everything necessary since I need to flesh out all of thecollectphase).alias.wast,module-link.wast,resources.wast,type-export-restrictions.wast,round_trip_component.rs, andexport-introduces-alias.wast), and more...plus -- whamm won't work until I have this either!Fix workarounds
(core func ... (canon resource.drop ...))is syntax output by the printer to show that a core function is generated for the component function on instantiation and given an ID. I need to figure out how to identify this in my own IR since I need to know IDs at instrumentation time.Testing
Usability
- Also, add the docsrs configuration for enabling all features when it actually runs, so you'll always be able to see documentation for your new feature going forward
- Use
cargo doc --document-private-itemsto document, code for doing this in docs.rs upon publish:- A new feature flag may be ideal to ensure no downstream impact
- Ensure default feature flags (
default = [])- Hide/optionally include new deps that may be required (
your-new-feature = ['dep:some-new-dep', ...])