Skip to content

fix: add single item to favorites list one time #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MohammadTeeU wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add single item to favorites list one time #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 26 additions & 9 deletions lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,27 @@ class _MyHomePageState extends State<MyHomePage> {
child: Text(user.phone),
),
),
IconButton(
icon: Icon(Icons.add),
onPressed: () {
// var favoritesViewModel = context.read<FavoritesViewModel>();
var favoritesViewModel = Provider.of<UsersViewModel>(context, listen: false);
favoritesViewModel.insert(user);
Consumer<UsersViewModel>(
builder: (context, usersViewModel, child) {
if (!usersViewModel.iFFav(user)) {
return IconButton(
icon: Icon(Icons.add),
onPressed: () {
// var favoritesViewModel = context.read<FavoritesViewModel>();

var favoritesViewModel =
Provider.of<UsersViewModel>(context, listen: false);
favoritesViewModel.insert(user);
},
);
} else {
return IconButton(
icon: Icon(Icons.download_done),
onPressed: () {
debugPrint('it is in favorites');
},
);
}
},
),
],
Expand Down Expand Up @@ -100,11 +115,12 @@ class _MyHomePageState extends State<MyHomePage> {
title: Text(widget.title),
actions: [
IconButton(
onPressed: () => Navigator.of(context).push(MaterialPageRoute(builder: (_context) => FavoritesPage())),
onPressed: () => Navigator.of(context).push(
MaterialPageRoute(builder: (_context) => FavoritesPage())),
icon: Consumer<UsersViewModel>(
builder: (context, favoritesViewModel, child) => Text(
'${favoritesViewModel.favorites.length}',
style: Theme.of(context).textTheme.headline4,
style: TextStyle(fontSize: 15),
),
),
),
Expand All @@ -113,7 +129,8 @@ class _MyHomePageState extends State<MyHomePage> {
body: Center(child: Consumer<UsersViewModel>(
builder: (context, usersViewModel, child) {
debugPrint('building users list..');
debugPrint('usersViewModel.loadingState: ${usersViewModel.loadingState}');
debugPrint(
'usersViewModel.loadingState: ${usersViewModel.loadingState}');

if (usersViewModel.loadingState == LoadingState.loading) {
return const Center(child: CircularProgressIndicator());
Expand Down
17 changes: 12 additions & 5 deletions lib/models/users_viewmodel.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,11 @@ class UsersViewModel extends ChangeNotifier {
notifyListeners();
}

void fetchUsers() async {

bool iFFav(User user) {
return favorites.contains(user);
}

void fetchUsers() async {
loadingState = LoadingState.loading;
notifyListeners();

Expand All @@ -38,16 +40,21 @@ class UsersViewModel extends ChangeNotifier {
debugPrint('response.statusCode: ${response.statusCode}');
var jsonUsers = jsonDecode(response.body);
// jsonUsers[0]['name'] = null;
var users = jsonUsers.map<User>((_userJson) => User.fromJson(_userJson)).toList();
var users =
jsonUsers.map<User>((_userJson) => User.fromJson(_userJson)).toList();

// debugPrint('users.length: ${users.length}');
usersResponse = Tuple2(null, users);
notifyListeners();
} catch (e) {
if (response?.statusCode == 200) {
usersResponse = Tuple2(ErrorResponse('توجد مشكلة في عرض المعلومات', response?.statusCode), null);
usersResponse = Tuple2(
ErrorResponse('توجد مشكلة في عرض المعلومات', response?.statusCode),
null);
} else {
usersResponse = Tuple2(ErrorResponse('لا يمكن الإتصال. يرجى المحاولة فيما بعد...', -1), null);
usersResponse = Tuple2(
ErrorResponse('لا يمكن الإتصال. يرجى المحاولة فيما بعد...', -1),
null);
}

debugPrint('e: $e');
Expand Down