Open
Conversation
Signed-off-by: Uilian Ries <uilianries@gmail.com>
3 tasks
czoido
reviewed
Sep 7, 2023
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
czoido
reviewed
Sep 7, 2023
| return EXIT_SUCCESS; | ||
| } | ||
|
|
||
| The *Makefile* specifies that ``logger`` is the expected executable and that it should be linked to the ``spdlog`` and ``fmt`` libraries. |
Contributor
There was a problem hiding this comment.
Maybe this comes from copy&paste from other example? I can't see anything about fmt or spdlog there
Member
Author
There was a problem hiding this comment.
It's a copy and paste indeed, but spdlog and fmt is correct. The spdlog depends on fmt:
% conan graph build-order --requires=spdlog/1.12.0
======== Computing dependency graph ========
Graph root
cli
Requirements
fmt/10.1.0#51d8d1db43672712db81b146a85ca73d - Cache
spdlog/1.12.0#248c215bc5f0718402fbf1de126ef847 - Cache
Contributor
There was a problem hiding this comment.
What I mean is that there's nothing in the Makefile about fmt or spdlog, it's a bit confusing for me
Member
Author
There was a problem hiding this comment.
@czoido I just updated the statement for global variables. Then, mentioned about separated variables.
czoido
reviewed
Sep 7, 2023
| In this case, we will use :ref:`MakeDeps<conan_tools_gnu_makedeps>` to generate information about where the **spdlog** library | ||
| files are installed thanks to the `makedeps.mk` file and using a `conanbuild[.sh|.bat]` file that describes the compilation environment. | ||
|
|
||
| We will use Conan to install **spdlog** library, generate a dependency file for Makefile, for find **spdlog** and **fmt** by make. |
Member
Author
There was a problem hiding this comment.
Removed all references about fmt as it's not out main dependency.
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new section using the Examples2 with MakeDeps
Related to the PR conan-io/examples2#115
Current view: