Open
Conversation
|
|
Member
|
Thanks a lot for taking the time to improve the docs, we appreciate it! I think it would be easier to note in which methods access to |
memsharded
reviewed
Mar 25, 2025
Member
memsharded
left a comment
memsharded
left a comment
There was a problem hiding this comment.
This might be a bit more complicated than this.
The issue is that the conf is available in other places, as long as it comes from profiles files.
It is the usage of conf coming from tool_requires that is expected to be limited, because those tool_requires might not be necessarily available (skipped), and their package_info() won't even execute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses comments from @memsharded in conan-io/conan#18008 about which methods are allowed to rely on the data in
ConanFile.conf.I just added a quick note, but it would be great to discuss some more helpful suggestions for people who need these configuration values elsewhere in their recipe.