Skip to content

Conversation

@danimtb
Copy link
Member

@danimtb danimtb commented Nov 21, 2025

Use the examples with Conan client changes at conan-io/conan#19345

danimtb and others added 4 commits November 21, 2025 13:29
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
…o/examples2 into danimtb/extension-plugin-pkgsign
…o/examples2 into danimtb/extension-plugin-pkgsign
@czoido
Copy link
Contributor

czoido commented Feb 9, 2026

All this code should be explained in an example, in the examples section of the docs: https://docs.conan.io/2/examples.html as a part of this PR: conan-io/docs#4365 or in a separate one if you prefer.

@danimtb
Copy link
Member Author

danimtb commented Feb 9, 2026

All this code should be explained in an example, in the examples section of the docs: https://docs.conan.io/2/examples.html as a part of this PR: conan-io/docs#4365 or in a separate one if you prefer.

I agree! Let's add it in a different PR

danimtb and others added 9 commits February 10, 2026 17:45
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
@czoido
Copy link
Contributor

czoido commented Feb 11, 2026

I'm a bit concerned about not being clear that this is just an example and we are not taking into account best practices for security, may we add a comment in the code similar to this:

"""
SECURITY NOTE:
This example stores a private key next to the plugin for simplicity. Do not do this in production.
Instead, load the signing key from environment variables or a secret manager, or delegate signing to a remote signing service.
Always keep the private key out of the Conan cache and out of source control.
"""

and also notes in the READMEs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants