Conversation
|
I've added the Amsel-2012-559 dataset, @AnnikaTjuka, would you mind moderating this PR? |
|
Sure, I can moderate this PR. @chrzyki Would you have time to review this PR? @MiraAhmedovic Could you provide the Google Doc? |
|
Change of plans... @FredericBlum Would you have time to review this PR? |
FredericBlum
left a comment
FredericBlum
left a comment
There was a problem hiding this comment.
Sure, I just checked the PR. I only have a few minor comments on some of the concepts, most of which relate to issues external of this conceptlist.
| Amsel-2012-559-358 358 pheasant 3060 PHEASANT 5.69 2.6 3.67 3.36 4.45 3.96 2.5 4.74 | ||
| Amsel-2012-559-359 359 piano 3994 PIANO (INSTRUMENT) 7.52 03.09 02.05 03.08 1.83 6.12 1.5 3 | ||
| Amsel-2012-559-360 360 pickle 7.53 1.74 6.39 4.85 5.45 1.42 7.95 1.75 | ||
| Amsel-2012-559-361 361 pie 7.61 1.82 6.43 4.64 7.5 1.88 06.05 1.63 |
There was a problem hiding this comment.
I'd like to start the pie vs cake vs kuchen debate here. Are they the same? Are they not?
There was a problem hiding this comment.
I'd say pie and cake are two distinct concepts since cake is usually sweet whereas pie can totally be savory. German seems to allow a stretch when it comes to Kuchen (I'd usually associate the term with a sweet baked good) in cases like "Zwiebelkuchen" or "Flammkuchen" but since those are further specified, I'd say cake = Kuchen in the general sense whereas pie is more like an Auflauf (?).
There was a problem hiding this comment.
I think something else to consider in this debate is tarte vs. pie. Is a tarte just a shallow pie? I'm currently struggling whether to map Spanish "tarta" to CAKE or a new concept PIE.
There was a problem hiding this comment.
@MiraAhmedovic Could you open an issue where we can discuss this further? You could also provide a list with current mappings and inconsistencies.
| Amsel-2012-559-422 422 saxophone 4024 SAXOPHONE 7.15 2.42 1.84 5.86 02.09 6.32 5.36 3.32 | ||
| Amsel-2012-559-423 423 scarf 3066 SCARF OR TURBAN 7.38 02.08 1.54 6.15 1.71 1 7.42 1.82 | ||
| Amsel-2012-559-424 424 schoolbus 7.56 3.81 3.96 6.61 1.46 5.58 1.91 6.77 | ||
| Amsel-2012-559-425 425 scissors 356 SHEARS 7.66 5.54 1.18 03.05 1.52 2.12 7.54 2.7 |
There was a problem hiding this comment.
I think so. Other instances of "scissors" are usually mapped to SHEARS.
There was a problem hiding this comment.
Good catch, @FredericBlum! @MiraAhmedovic You can check the REPLACEMENT ID column in concepticon.tsv to see if the concept is retired.
There was a problem hiding this comment.
Yes, 356 SHEARS is given as a replacement ID for 1328 SCISSORS in concepticon.tsv.
| Amsel-2012-559-453 453 sled 16 SLED 07.01 4.75 1.26 4.14 1.71 2.91 3.26 5.23 | ||
| Amsel-2012-559-454 454 sledgehammer 6.85 7.58 1.5 2.86 1.61 6.45 5.38 4.42 | ||
| Amsel-2012-559-455 455 sleigh 6.69 3.29 1.73 4.61 1.83 2.71 2.59 5.33 | ||
| Amsel-2012-559-456 456 slingshot 07.05 6.22 1.43 2.62 1.77 03.09 6.75 4.71 |
There was a problem hiding this comment.
Could be considered for a new concept, we already have it four times in the data
| Amsel-2012-559-467 467 spider 843 SPIDER 7.56 4.64 1.64 2.6 1.63 1.64 5.3 06.04 | ||
| Amsel-2012-559-468 468 spinach 975 SPINACH 7.47 1.78 3.58 6.15 6.26 01.05 6.13 1.23 | ||
| Amsel-2012-559-469 469 spoon 1378 SPOON 7.57 1.52 1.86 3.36 2.7 02.05 7.9 2.82 | ||
| Amsel-2012-559-470 470 squid 7.15 3.65 05.08 3.17 05.04 1.92 4.71 5.95 |
There was a problem hiding this comment.
For some reason, 'squid' has frequently been linked to INK: https://concepticon.clld.org/parameters/2643
This should probably be fixed, and SQUID added as concept instead?
AnnikaTjuka
left a comment
AnnikaTjuka
left a comment
There was a problem hiding this comment.
I commented on the discussion points, but everythingelse looks good!
3 participants
Pull request checklist
concepticon notlinked --gloss "NEW_GLOSS"Additional information
Adding Amsel-2012-559 based on Perceptual and motor attribute ratings for 559 object concepts by Amsel et al. (2012). Closes #1498.