Merged
Conversation
This commit introduces a publish-subscribe (pub/sub) mechanism to facilitate communication between managed interactives within the Activity Player. The PubSubManager class handles the creation of channels, publishing messages, and managing subscriptions.
scytacki
approved these changes
Dec 23, 2025
Member
scytacki
left a comment
scytacki
left a comment
There was a problem hiding this comment.
Any reason this is limited to managed interactives? It seems like it could work for interactives that are setup directly by authors too. I didn't look at the code carefully though, perhaps the managed interactive class is used by the other interactives too.
activity-player
|
||||||||||||||||||||||||||||
| Project |
activity-player
|
| Branch Review |
AP-58-add-pub-sub-support
|
| Run status |
|
| Run duration | 05m 12s |
| Commit |
|
| Committer | Doug Martin |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
96
|
| View all changes introduced in this branch ↗︎ | |
Member
Author
It is used for both managed and MWInteractives. You can see that here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a publish-subscribe (pub/sub) mechanism to facilitate communication between managed interactives within the Activity Player. The PubSubManager class handles the creation of channels, publishing messages, and managing subscriptions.