feat: Update orange button styling for WCAG accessibility [AP-66]#542
Merged
dougmartin merged 2 commits intomasterfrom Mar 4, 2026
Merged
feat: Update orange button styling for WCAG accessibility [AP-66]#542dougmartin merged 2 commits intomasterfrom
dougmartin merged 2 commits intomasterfrom
Conversation
Update .button class colors and add keyboard focus indicator to meet WCAG AAA contrast ratios. Add $cc-button-* SCSS variables for new color palette. Remove dead hover rule from disabled button override. Spec: specs/AP-66-update-orange-button-styling.md
There was a problem hiding this comment.
Pull request overview
Updates the Activity Player’s shared .button styling to meet WCAG contrast/accessibility requirements by introducing a new button-specific color palette and adding a keyboard-visible focus indicator.
Changes:
- Added
$cc-button-*SCSS variables for default/hover/click/border/focus-ring colors. - Updated
.buttonstyles inapp.scss(default, hover, active, and new:focus-visiblering). - Removed unreachable
:hoverstyling from the disabled override in bottom buttons; added an implementation spec document.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/components/vars.scss |
Introduces new button palette variables used by shared .button styling. |
src/components/app.scss |
Applies new colors and adds :focus-visible focus ring styling to .button. |
src/components/activity-page/bottom-buttons.scss |
Cleans up dead disabled-hover rule under pointer-events: none. |
specs/AP-66-update-orange-button-styling.md |
Documents the accessibility requirements, palette, and rationale/decisions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
activity-player
|
||||||||||||||||||||||||||||
| Project |
activity-player
|
| Branch Review |
AP-66-update-orange-button-styling
|
| Run status |
|
| Run duration | 05m 11s |
| Commit |
|
| Committer | Doug Martin |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
96
|
| View all changes introduced in this branch ↗︎ | |
The reset button's SVG icon in iframe-runtime.scss previously used hardcoded fill values ($cc-charcoal default, white on :active) that matched the old .button text color behavior. With the AP-66 button styling update, :active no longer changes text to white, so the hardcoded white fill became a visual mismatch. Replace with currentColor so the icon always inherits the button text color.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update .button class colors and add keyboard focus indicator to meet WCAG AAA contrast ratios. Add $cc-button-* SCSS variables for new color palette. Remove dead hover rule from disabled button override.
Spec: specs/AP-66-update-orange-button-styling.md