fix: Switch all versioned QI urls to master in sample activities#543
Merged
dougmartin merged 2 commits intomasterfrom Mar 6, 2026
Merged
fix: Switch all versioned QI urls to master in sample activities#543dougmartin merged 2 commits intomasterfrom
dougmartin merged 2 commits intomasterfrom
Conversation
Some of the question interactive urls in the sample activities were pinned to a specific version number, including the default sample activity. This change converts all of them to master. This came up because the sample activity was used to verify that a merged styling change to question interactives was made and it caused confusion when the sample activity did not show the change.
activity-player
|
||||||||||||||||||||||||||||
| Project |
activity-player
|
| Branch Review |
unpin-sample-activity-versions
|
| Run status |
|
| Run duration | 05m 16s |
| Commit |
|
| Committer | Doug Martin |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
96
|
| View all changes introduced in this branch ↗︎ | |
There was a problem hiding this comment.
Pull request overview
Updates sample activity content to ensure Question Interactive (QI) references point at the master branch endpoints rather than pinned version URLs, so sample activities reflect the latest QI changes during verification.
Changes:
- Replaced version-pinned QI
base_urlvalues withhttps://models-resources.concord.org/question-interactives/branch/master/...across multiple sample activity JSON files. - Updated embedded QI URLs inside a scaffolded
authored_stateblob to also reference themasterbranch.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/data/version-2/sample-new-sections-activity-2.json | Switches remaining version-pinned QI base_url entries to branch/master. |
| src/data/sample-activity-waters.json | Converts multiple QI base_url entries (and embedded scaffolded subinteractive URLs) from version-pinned to branch/master. |
| src/data/sample-activity-responsive-50-50-layout.json | Updates QI base_url entries from version-pinned to branch/master. |
| src/data/sample-activity-multiple-layout-types.json | Updates numerous QI base_url entries from version-pinned to branch/master. |
| src/data/sample-activity-2.json | Switches remaining version-pinned open-response QI URLs to branch/master. |
| src/data/sample-activity-1100px.json | Updates the version-pinned open-response QI URL to branch/master. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ox to master in sample activities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the question interactive urls in the sample activities were pinned to a specific version number, including the default sample activity. This change converts all of them to master.
This came up because the sample activity was used to verify that a merged styling change to question interactives was made and it caused confusion when the sample activity did not show the change.