Closed
Conversation
Author
|
need to test this but that's the idea |
esposem
force-pushed
the
improvements
branch
2 times, most recently
from
f401d9e to
d582e8f
Compare
We don't need Trustee if one wants to just generate the sidecar or improve a manifest. Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Not only the certs. Can be useful when we want to add certificates into Trustee manually and permanently. Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Allow the user to define its own custom directory where to store keys and certs. Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
If trustee is not set in config, we want to also skip adding initdata annotations. Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
As now it could also be empty. Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
This reverts commit dff529b.
Contributor
|
After merging of this #22, |
Author
|
Closed in favor of #24 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apply: introduce --no-initdata to skip adding annotation
init: introduce --cert-dir to store certs and keys
init: save all keys and certificates locally
init: add --no-upload flag to not upload anything into Trustee