-
Notifications
You must be signed in to change notification settings - Fork 18
edig gh_secrets img #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edig gh_secrets img #642
Conversation
|
🤖 Hi @harikae86, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📋 Review Summary
This pull request updates an image file name from gh_secrets.png to github_secrets.png and updates its references in the documentation. The changes are straightforward and improve the clarity of the file name.
🔍 General Feedback
- The changes are consistent across all modified files.
- There is a minor typo in the
alttext of the images, where "Github" should be "GitHub". I've added suggestions to fix this.
|
|
||
| ## Setup | ||
|
|
||
| 1. Create a new <a target="_blank" href="https://app.configcat.com/my-account/public-api-credentials">ConfigCat Management API credential</a> and store its values in your repository's <a target="_blank" href="https://docs.github.com/en/actions/security-guides/encrypted-secrets#creating-encrypted-secrets-for-a-repository">GitHub Secrets</a> with the following names: `CONFIGCAT_API_USER`, `CONFIGCAT_API_PASS`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 In alt text, "Github" should be capitalized as "GitHub" for consistency with the brand name.
| 1. Create a new <a target="_blank" href="https://app.configcat.com/my-account/public-api-credentials">ConfigCat Management API credential</a> and store its values in your repository's <a target="_blank" href="https://docs.github.com/en/actions/security-guides/encrypted-secrets#creating-encrypted-secrets-for-a-repository">GitHub Secrets</a> with the following names: `CONFIGCAT_API_USER`, `CONFIGCAT_API_PASS`. | |
| <img src="/docs/assets/cli/scan/github_secrets.png" alt="GitHub Action secrets" decoding="async" loading="lazy" /> |
| Store the credential in your repository's <a target="_blank" href="https://docs.github.com/en/actions/security-guides/encrypted-secrets#creating-encrypted-secrets-for-a-repository">GitHub Secrets</a> with the following names: `CONFIGCAT_API_USER`, `CONFIGCAT_API_PASS`. | ||
|
|
||
| <img src="/docs/assets/cli/scan/gh_secrets.png" alt="Github Action secrets" decoding="async" loading="lazy" /> | ||
| <img src="/docs/assets/cli/scan/github_secrets.png" alt="Github Action secrets" decoding="async" loading="lazy" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 In alt text, "Github" should be capitalized as "GitHub" for consistency with the brand name.
| <img src="/docs/assets/cli/scan/github_secrets.png" alt="Github Action secrets" decoding="async" loading="lazy" /> | |
| <img src="/docs/assets/cli/scan/github_secrets.png" alt="GitHub Action secrets" decoding="async" loading="lazy" /> |
|
|
||
| ## Setup | ||
|
|
||
| 1. Create a new <a target="_blank" href="https://app.configcat.com/my-account/public-api-credentials">ConfigCat Management API credential</a> and store its values in your repository's <a target="_blank" href="https://docs.github.com/en/actions/security-guides/encrypted-secrets#creating-encrypted-secrets-for-a-repository">GitHub Secrets</a> with the following names: `CONFIGCAT_API_USER`, `CONFIGCAT_API_PASS`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 In alt text, "Github" should be capitalized as "GitHub" for consistency with the brand name.
| 1. Create a new <a target="_blank" href="https://app.configcat.com/my-account/public-api-credentials">ConfigCat Management API credential</a> and store its values in your repository's <a target="_blank" href="https://docs.github.com/en/actions/security-guides/encrypted-secrets#creating-encrypted-secrets-for-a-repository">GitHub Secrets</a> with the following names: `CONFIGCAT_API_USER`, `CONFIGCAT_API_PASS`. | |
| <img src="/docs/assets/cli/scan/github_secrets.png" alt="GitHub Action secrets" decoding="async" loading="lazy" /> |
| Store the credential in your repository's <a target="_blank" href="https://docs.github.com/en/actions/security-guides/encrypted-secrets#creating-encrypted-secrets-for-a-repository">GitHub Secrets</a> with the following names: `CONFIGCAT_API_USER`, `CONFIGCAT_API_PASS`. | ||
|
|
||
| <img src="/docs/assets/cli/scan/gh_secrets.png" alt="Github Action secrets" decoding="async" loading="lazy" /> | ||
| <img src="/docs/assets/cli/scan/github_secrets.png" alt="Github Action secrets" decoding="async" loading="lazy" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 In alt text, "Github" should be capitalized as "GitHub" for consistency with the brand name.
| <img src="/docs/assets/cli/scan/github_secrets.png" alt="Github Action secrets" decoding="async" loading="lazy" /> | |
| <img src="/docs/assets/cli/scan/github_secrets.png" alt="GitHub Action secrets" decoding="async" loading="lazy" /> |
Deploying configcat-docs with
|
| Latest commit: |
ca30629
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5c8cb091.docs-xmy.pages.dev |
| Branch Preview URL: | https://edit-img.docs-xmy.pages.dev |
Describe the purpose of your pull request
Related issues (only if applicable)
How to test? (only if applicable)
Requirement checklist