Skip to content

Conversation

@harikae86
Copy link
Contributor

Describe the purpose of your pull request

  • Provide a clear and concise description of the changes.

Related issues (only if applicable)

  • Provide links to issues relating to this pull request.

How to test? (only if applicable)

  • What part of the application was affected by the changes? What should be tested?

Requirement checklist

  • I have validated my changes on a test/local environment.
  • I have tested that the code snippets I added work. (Leave unchecked if there are no new code snippets.)
  • I have added my changes to the V1 and V2 documentations.

@harikae86 harikae86 requested a review from a team as a code owner January 7, 2026 10:09
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

🤖 Hi @harikae86, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This pull request updates an image file name from gh_secrets.png to github_secrets.png and updates its references in the documentation. The changes are straightforward and improve the clarity of the file name.

🔍 General Feedback

  • The changes are consistent across all modified files.
  • There is a minor typo in the alt text of the images, where "Github" should be "GitHub". I've added suggestions to fix this.


## Setup

1. Create a new <a target="_blank" href="https://app.configcat.com/my-account/public-api-credentials">ConfigCat Management API credential</a> and store its values in your repository's <a target="_blank" href="https://docs.github.com/en/actions/security-guides/encrypted-secrets#creating-encrypted-secrets-for-a-repository">GitHub Secrets</a> with the following names: `CONFIGCAT_API_USER`, `CONFIGCAT_API_PASS`.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 In alt text, "Github" should be capitalized as "GitHub" for consistency with the brand name.

Suggested change
1. Create a new <a target="_blank" href="https://app.configcat.com/my-account/public-api-credentials">ConfigCat Management API credential</a> and store its values in your repository's <a target="_blank" href="https://docs.github.com/en/actions/security-guides/encrypted-secrets#creating-encrypted-secrets-for-a-repository">GitHub Secrets</a> with the following names: `CONFIGCAT_API_USER`, `CONFIGCAT_API_PASS`.
<img src="/docs/assets/cli/scan/github_secrets.png" alt="GitHub Action secrets" decoding="async" loading="lazy" />

Store the credential in your repository's <a target="_blank" href="https://docs.github.com/en/actions/security-guides/encrypted-secrets#creating-encrypted-secrets-for-a-repository">GitHub Secrets</a> with the following names: `CONFIGCAT_API_USER`, `CONFIGCAT_API_PASS`.

<img src="/docs/assets/cli/scan/gh_secrets.png" alt="Github Action secrets" decoding="async" loading="lazy" />
<img src="/docs/assets/cli/scan/github_secrets.png" alt="Github Action secrets" decoding="async" loading="lazy" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 In alt text, "Github" should be capitalized as "GitHub" for consistency with the brand name.

Suggested change
<img src="/docs/assets/cli/scan/github_secrets.png" alt="Github Action secrets" decoding="async" loading="lazy" />
<img src="/docs/assets/cli/scan/github_secrets.png" alt="GitHub Action secrets" decoding="async" loading="lazy" />


## Setup

1. Create a new <a target="_blank" href="https://app.configcat.com/my-account/public-api-credentials">ConfigCat Management API credential</a> and store its values in your repository's <a target="_blank" href="https://docs.github.com/en/actions/security-guides/encrypted-secrets#creating-encrypted-secrets-for-a-repository">GitHub Secrets</a> with the following names: `CONFIGCAT_API_USER`, `CONFIGCAT_API_PASS`.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 In alt text, "Github" should be capitalized as "GitHub" for consistency with the brand name.

Suggested change
1. Create a new <a target="_blank" href="https://app.configcat.com/my-account/public-api-credentials">ConfigCat Management API credential</a> and store its values in your repository's <a target="_blank" href="https://docs.github.com/en/actions/security-guides/encrypted-secrets#creating-encrypted-secrets-for-a-repository">GitHub Secrets</a> with the following names: `CONFIGCAT_API_USER`, `CONFIGCAT_API_PASS`.
<img src="/docs/assets/cli/scan/github_secrets.png" alt="GitHub Action secrets" decoding="async" loading="lazy" />

Store the credential in your repository's <a target="_blank" href="https://docs.github.com/en/actions/security-guides/encrypted-secrets#creating-encrypted-secrets-for-a-repository">GitHub Secrets</a> with the following names: `CONFIGCAT_API_USER`, `CONFIGCAT_API_PASS`.

<img src="/docs/assets/cli/scan/gh_secrets.png" alt="Github Action secrets" decoding="async" loading="lazy" />
<img src="/docs/assets/cli/scan/github_secrets.png" alt="Github Action secrets" decoding="async" loading="lazy" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 In alt text, "Github" should be capitalized as "GitHub" for consistency with the brand name.

Suggested change
<img src="/docs/assets/cli/scan/github_secrets.png" alt="Github Action secrets" decoding="async" loading="lazy" />
<img src="/docs/assets/cli/scan/github_secrets.png" alt="GitHub Action secrets" decoding="async" loading="lazy" />

@cloudflare-workers-and-pages
Copy link

Deploying configcat-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: ca30629
Status: ✅  Deploy successful!
Preview URL: https://5c8cb091.docs-xmy.pages.dev
Branch Preview URL: https://edit-img.docs-xmy.pages.dev

View logs

@harikae86 harikae86 merged commit 287819d into master Jan 7, 2026
7 of 8 checks passed
@harikae86 harikae86 deleted the edit-img branch January 7, 2026 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants