-
Notifications
You must be signed in to change notification settings - Fork 4
Composer package #1
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for the additions. I'd be happy to merge, but for a small issue. I have a concern around the use of the CURLFile class: CURLFile was only added as part of PHP 5.5 (according to the manual) and, sadly, 5.5 still isn't as widely supported in the general hosting community as I'd like. (Partly due to the reluctance of RedHat/CentOS to package it in standard yum repos, even with the recent version 7 releases.) Perhaps rather than assuming that the class will be available, wrap the $postFields['File'] = new \CurlFile($filename); lines in class_exists calls, and fall back to the previous method? I notice in composer.json you have "php": ">= 5.4" as a requirement. Other than CurlFile is there something else in the code that you're aware of which requires 5.4? (You might well be right, by the way, I haven't modified this library for a while so I don't remember!) |
…ps-for-convert-api PLATFORM-29: Change http to https for convert api
add uploading files via curlopt_file
|
@knyga @confuzzledduck Hi guys, just wondering if there's any chance of this happening? In the meantime I can use knyga's fork. |
It is much better to have this project as composer project. I configured all, you can just push it to packagist.
Thank you,
Oleksandr Knyga
oleksandrknyga@gmail.com