Skip to content
This repository was archived by the owner on Apr 30, 2020. It is now read-only.

Conversation

@knyga
Copy link

@knyga knyga commented Nov 29, 2014

It is much better to have this project as composer project. I configured all, you can just push it to packagist.

Thank you,
Oleksandr Knyga
oleksandrknyga@gmail.com

@confuzzledduck
Copy link
Owner

Thanks for the additions. I'd be happy to merge, but for a small issue.

I have a concern around the use of the CURLFile class: CURLFile was only added as part of PHP 5.5 (according to the manual) and, sadly, 5.5 still isn't as widely supported in the general hosting community as I'd like. (Partly due to the reluctance of RedHat/CentOS to package it in standard yum repos, even with the recent version 7 releases.) Perhaps rather than assuming that the class will be available, wrap the $postFields['File'] = new \CurlFile($filename); lines in class_exists calls, and fall back to the previous method?

I notice in composer.json you have "php": ">= 5.4" as a requirement. Other than CurlFile is there something else in the code that you're aware of which requires 5.4? (You might well be right, by the way, I haven't modified this library for a while so I don't remember!)

@Dayjo
Copy link

Dayjo commented Jul 21, 2016

@knyga @confuzzledduck Hi guys, just wondering if there's any chance of this happening? In the meantime I can use knyga's fork.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants