Open
Conversation
Owner
|
@developit Awesome! However, I don't think this feature should be specific to toolbars. Icon inputs should be a feature available anywhere in the application. So the base markup structure should probably be something like: <div class="form-icon-text-group form-group">
<span class="icon icon-search"></span>
<input type="search" class="form-control" placeholder="Search...">
</div>Then the SASS could be something like: .form-icon-text-group {
position: relative;
.icon {
position: absolute;
top: 4px;
left: 10px;
z-index: 1;
}
.form-control {
padding-left: 25px;
}
}Lastly, to get things working in the toolbar, all you have to do is remove the |
Contributor
Author
|
Agreed regarding a generic solution. That markup works for me. |
|
any updates on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
toolbar-input. I couldnt decide on markup for a generic input with inset icon.This at least partly addresses #14.
JSFiddle: http://jsfiddle.net/developit/aqu10kd9/
*Preview:
Markup:
*the zoom border effect is not included in this PR