Transport support for Skpr#66
Merged
greg-1-anderson merged 2 commits intoconsolidation:mainfrom Dec 1, 2022
Merged
Conversation
Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>
Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #66 +/- ##
============================================
- Coverage 78.46% 77.22% -1.25%
- Complexity 165 172 +7
============================================
Files 18 20 +2
Lines 418 439 +21
============================================
+ Hits 328 339 +11
- Misses 90 100 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Might be better to contribute to this #61 and then provide docs on the platforms site. |
Member
|
Maybe everything should have been done like #61, but I am left with questions on that approach. It seems safer to make each transport explicit, so that each one can define the parameters it needs, do any special processing that is appropriate, and etc. If nothing else, it's easier to make a decision about a single well-defined transport. That's why I am merging here, and am still undecided about #61. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request:
Summary
Enables support for Drush commands to wrap skpr commands, enabling users on the Skpr platform to be able to use Drush and/or Drush focused scripts for management, migration, debugging etc.
Description
I really loved that this could enable me to interface with Drupal via kubectl commands, we saw this as an opportunity to do the same with our
skprcommand line tool - because developers using our platform won't have access to kubectl for their day-to-day work.I've modeled this work based on the kubectl transport work, and it's working quite nicely.