fix!: Switch interface to consistent snake_case naming#65
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the codebase to standardize naming conventions by converting camelCase method names to snake_case format, improving consistency with Python naming conventions and making the API more idiomatic.
- Renamed methods in SO3 and SE3 classes (e.g.,
fromMat→from_mat,toMat→to_mat,toEigen→to_eigen) - Updated string conversion methods (e.g.,
toString→to_string,toStringBrief→to_string_brief) - Refactored C++ binding functions to use snake_case (e.g.,
makeTypes→make_types,makePipelines→make_pipelines)
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_so3.py | Updated test to use from_mat instead of fromMat |
| tests/test_se3.py | Updated tests to use from_mat and to_mat instead of camelCase versions |
| python/evalio/datasets/multi_campus.py | Updated SE3 instantiation to use from_mat |
| python/evalio/datasets/helipr.py | Updated SO3 instantiation to use from_mat |
| python/evalio/datasets/cumulti.py | Updated SE3 instantiation to use from_mat |
| python/evalio/datasets/botanic_garden.py | Updated SE3 instantiation to use from_mat |
| cpp/evalio/types.h | Renamed all camelCase methods to snake_case in Duration, Stamp, Point, LidarMeasurement, LidarParams, ImuMeasurement, ImuParams, SO3, and SE3 structs |
| cpp/evalio/convert/sophus.h | Updated Sophus conversion to use to_eigen |
| cpp/bindings/types.h | Updated Python bindings to use snake_case method names and renamed makeTypes to make_types |
| cpp/bindings/ros_pc2.h | Renamed makeConversions to make_conversions |
| cpp/bindings/pipelines/loam.h | Updated LOAM conversion to use from_eigen |
| cpp/bindings/pipelines/lio_sam.h | Updated LIO-SAM to use to_eigen |
| cpp/bindings/pipelines/ct_icp.h | Updated CT-ICP conversion to use from_mat |
| cpp/bindings/pipelines/bindings.h | Renamed makePipelines to make_pipelines |
| cpp/bindings/pipeline.h | Renamed makeBasePipeline to make_base_pipeline |
| cpp/bindings/main.cpp | Updated all function calls to use new snake_case names |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a handful of the API that had left over camelCase usage. Switch them all to snake_case.