adaptation: honor context deadline in WASM runtime/plugins. #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use the default wazero runtime. Instead use one with a ModuleConfig which has WithCloseOnContextDone(true) set. This causes calls to WASM plugins to properly obey context deadlines which otherwise they don't. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Don't try to make further calls to closed WASM plugins. Mark them as closed in close(), so they get properly removed from the list of plugins. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Member
Author
|
/cc @saschagrunert |
saschagrunert
approved these changes
Feb 4, 2025
Contributor
saschagrunert
left a comment
saschagrunert
left a comment
There was a problem hiding this comment.
Thank you, great find!
fuweid
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use the default wazero runtime configuration. Instead use one with `WithCloseOnContextDone(true) in order for calls to WASM plugins to properly obey context deadlines, which otherwise they don't. Also, once a WASM plugin is closed (for instance due to a request processing timeout), mark the plugin closed so it gets properly removed from the list of active plugins.
Fixes #138.