deps: bump runtime-spec to v1.3.0. #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klihub
force-pushed
the
devel/runtime-spec-v1.3.0
branch
from
ce6cad4 to
f5b81c3
Compare
Member
|
nice unwind... cypher just lgtm'd your 795 so this shouldn't need to be draft for long :) |
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Instead of using the in-repo NRI version, lock it to v0.10.0, the last tagged version with a runtime-spec dependency below v1.3.0, to prevent the incompatible Linux PIDS Limit pointer change from creeping in. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Instead of using the in-repo NRI version, lock it to v0.10.0, the last tagged version with a runtime-spec dependency below v1.3.0, to prevent the incompatible Linux PIDS Limit pointer change from creeping in. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
klihub
force-pushed
the
devel/runtime-spec-v1.3.0
branch
from
f5b81c3 to
29c5811
Compare
mikebrow
approved these changes
Nov 14, 2025
| github.com/opencontainers/runtime-spec v1.1.0 | ||
| github.com/opencontainers/runtime-tools v0.9.0 | ||
| github.com/opencontainers/runtime-spec v1.3.0 | ||
| github.com/opencontainers/runtime-tools v0.9.1-0.20251114084447-edf4cb3d2116 |
Member
There was a problem hiding this comment.
nit // runtime-tools has not tagged a release in six years have to move up to commit to resolve __
|
|
||
| const ( | ||
| // UnlimitedPidsLimit indicates unlimited Linux PIDs limit. | ||
| UnlimitedPidsLimit = -1 |
Member
There was a problem hiding this comment.
nit todo: define and retrieve from runtime-tools?
Member
There was a problem hiding this comment.
I guess runtime-tools might be eventually going to be deprecated, so this seems fine for now
AkihiroSuda
approved these changes
Nov 17, 2025
Member
|
Can we have a new git tag? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps our
opencontainers/runtime-specdependency tov1.3.0.In particular it
runtime-specandruntime-toolsdependency to matchruntime-spec v1.3.0v010-adapterplugin to depend on NRIv0.10.0andruntime-spec v1.1.0examplesto depend on NRIv0.10.0andruntime-spec v1.1.0