-
Notifications
You must be signed in to change notification settings - Fork 86
device-injector: always log injection summary. #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
device-injector: always log injection summary. #246
Conversation
chrishenzie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM outside of one comment
Log injection and other adjustment summary also in verbose mode. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
ee54476 to
14cc2e2
Compare
mikebrow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wdyt about:
if verbose .. log.Infof
else log.Debugf
|
@mikebrow I would expect applications to always write info/warn/error logs and not condition that behind anything, but optionally (additionally) log debug logs. Maybe this would be simpler if instead of |
nod.. guess we have not been consistent on the plugin log level vs verbosity flag options handled by each main() impl... maybe set the default in config.. anyhow I suppose this PR is better and we could use a discussion and normalization across the samples/plugins. |
mikebrow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Always log device injection summary, also in verbose mode.