Add support for sysctl adjustment #248
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing: unit tests including in the default validator. I have not yet built a new containerd binary with these changes and built a plugin to set sysctls. Let me know if you want to see that before merging.
Another note: right now the default validator configuration is
RejectSysctlAdjustmentand off by default, so either we can change that to a positive "AllowSysctlAdjustment" or we can turn it on by default in containerd when we integrate this change.