update wazero/wazero version to v1.10.1 #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Which commit fixed that? wazero/wazero#2362 (comment) says "not inclined to fix this" |
Contributor
Author
|
It should be https://github.com/wazero/wazero/commits/v1.10.1/ |
AkihiroSuda
approved these changes
Dec 11, 2025
Member
|
CI failing |
klihub
approved these changes
Dec 11, 2025
Member
|
@AkihiroSuda Can you re-approve this again, now with go.{mod,sum} now properly updated ? |
AkihiroSuda
approved these changes
Dec 11, 2025
Member
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
Thanks @klihub , LGTM
I suggest squashing the commits though
Signed-off-by: ningmingxiao <ning.mingxiao@zte.com.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try to fix containerd/containerd#12665