-
Notifications
You must be signed in to change notification settings - Fork 225
Fix broken gitignore exclude #2478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This matches all directories not just the top level one we wanted to ignore, however we no loner use or put anything into /build so we can just remove it instead. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Now that build is no longer incorrectly excluded it gets added. The fact that this did not cause a compile failure was just because gingko is used directly by the tests and not compiled from these sources. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Reviewer's GuideThis PR corrects an overly broad .gitignore rule by removing the top‐level “build” exclusion and regenerates vendor dependencies so the newly included files (previously ignored) are added. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, sourcery-ai[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Ouch - easy to forget how Gitignore semantics are not always a match for what we want to do. LGTM |
mtrmac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
4f0f579
into
containers:main
Possible replacement for containers#2476. I'm not sure if I messed something up when trying to merge in containers#2478 there, so thought I'd create this PR to see if I messed something up there when doing the merge/vendor. Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
Possible replacement for containers#2476. I'm not sure if I messed something up when trying to merge in containers#2478 there, so thought I'd create this PR to see if I messed something up there when doing the merge/vendor. Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
Possible replacement for containers#2476. I'm not sure if I messed something up when trying to merge in containers#2478 there, so thought I'd create this PR to see if I messed something up there when doing the merge/vendor. Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
Possible replacement for containers#2476. I'm not sure if I messed something up when trying to merge in containers#2478 there, so thought I'd create this PR to see if I messed something up there when doing the merge/vendor. Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
Possible replacement for containers#2476. I'm not sure if I messed something up when trying to merge in containers#2478 there, so thought I'd create this PR to see if I messed something up there when doing the merge/vendor. Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
.gitignore: do not ignore all build directories
This matches all directories not just the top level one we wanted to
ignore, however we no loner use or put anything into /build so we can
just remove it instead.
vendor: regenerate files
Now that build is no longer incorrectly excluded it gets added. The fact
that this did not cause a compile failure was just because gingko is
used directly by the tests and not compiled from these sources.
Summary by Sourcery
Fix .gitignore to stop excluding build directories and regenerate vendor files accordingly
Bug Fixes:
Chores: