use constants instead of adjustable data for game asset data#2
Open
GitMensch wants to merge 1 commit intocontextfreecode:mainfrom
Open
use constants instead of adjustable data for game asset data#2GitMensch wants to merge 1 commit intocontextfreecode:mainfrom
GitMensch wants to merge 1 commit intocontextfreecode:mainfrom
Conversation
letting the compiler specify the length "looks" clearer, but would yield the same result; it is possibly more useful to use `length of name-asset-data` in the code - or don't use that at all if it could be wrapped into a `CALL`able sub-program or user-defined function.
Contributor
|
Wow, I'm not good at noticing PRs. Thanks for submitting! I'll try to check it out next week. |
Author
|
Sounds good ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
letting the compiler specify the length "looks" clearer, but would yield the same result; it is possibly more useful to use
length of name-asset-datain the code - or don't use that at all if it could be wrapped into aCALLable sub-program or user-defined function.Warning: this is completely untested, just thought about that when viewing the video.