You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Dec 4, 2018. It is now read-only.
I have created a new arg flag keep-old-app, which skips deleting of the old app.
This was required by the project which currently work on.
We use Pivotal Cloud Foundry (PCF) container-to-container networking and Eureka service registry.
The way we use autopilot is the following (let's assume the service we are redeploying is called test-service:
Eureka has our test-service already registered
we run zero-downtime-push with -keep-old-app
test-service (the new app) and test-service-venerable (the old app) are both running, but the new app is not registered in Eureka because it cannot establish a connection to Eureka due to the missing c2c policies therefore all the requests are still routed to the old service
we run a script to set up the c2c policies
now since the new app is able to establish a connection to Eureka it can register itself
after some time, we run cf delete test-service-venerable to remove the old app
I would find it more useful to change the flag to an enumeration e.g. -old-app=remove|stop|none where remove is the default, none solves your case and stop solves my case #53.
What do you think?
I'm willing to help, unfortunately new to the language go.
@mibollma Good work on the code changes! I support the idea. Actually recently we have moved away from this plugin to the tool that does the same thing but just calls cf with appropriate commands (https://github.com/adamsiemion/pcf-zerodowntimedeploy). The main reason is the fact that we use plugins for Cloud Foundry in Jenkins and Urban Code Deploy, which only support the push command and does not allow to use zero-downtime-push instead.
@adamsiemion Thanks for your support. Hopefully @xoebus will find the time to take a look.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have created a new arg flag
keep-old-app, which skips deleting of the old app.This was required by the project which currently work on.
We use Pivotal Cloud Foundry (PCF) container-to-container networking and Eureka service registry.
The way we use
autopilotis the following (let's assume the service we are redeploying is calledtest-service:test-servicealready registeredzero-downtime-pushwith-keep-old-apptest-service(the new app) andtest-service-venerable(the old app) are both running, but the new app is not registered in Eureka because it cannot establish a connection to Eureka due to the missing c2c policies therefore all the requests are still routed to the old servicecf delete test-service-venerableto remove the old app