Fix stats track and inactive client reaping #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wss.clients is a Set rather than an Array after ws 2.x websockets/ws#934
wss.clients is a Set rather than an Array after ws 2.x websockets/ws#934
benmacleod
approved these changes
Jan 28, 2025
tiagoamaro
deleted the
18904-fix-stats-track-and-inactive-client-reaping
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We picked up this issue because the stats were returning nothing, so out of caution we rolled back to and older version in production until I could look at this again.
Turns out the type of
wss.clientschanged fromArraytoSet, so while all the document editing and so on was working fine, our stats tracking and inactive client reaping was not. This fixes both of those issues so we should be good to proceed with the upgrade again.(note that I added some temporary logging to make it more obvious when an inactive connection was reaped)
To test, run the
bin/exampleserverand visit http://localhost:8000/You should see the stats tracking in the example server working correctly (it currently does not on master).